ENH Convert to functional components#182
Draft
emteknetnz wants to merge 1 commit intosilverstripe:6.0from
Draft
Conversation
emteknetnz
force-pushed
the
pulls/6.0/js-deps
branch
from
4729a2e to
0adc403
Compare
2 tasks
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/6.0/js-deps
branch
2 times, most recently
from
dd415d0 to
84e844a
Compare
emteknetnz
force-pushed
the
pulls/6.0/js-deps
branch
from
84e844a to
5bf9a9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#336
Also updated the
qrcode.reactdep to the latest version. Because the latest version of that dep wasn't compatible with class components, all components in totp + mfa modules were upgarde to functional components.Incompatibility was seen with a console error
Warning: Invalid hook call. Hooks can only be called inside of the body of a function component.and the component was unable to renderUpdate: This PR is not complete, though I'll leave open in a draft state if we wish to swap to functional components in the future. You'll also want the corresponding mfa PR