Improve error handling#18
Merged
Merged
Conversation
✅ Deploy Preview for myhdf5 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit of a clean-up ahead of the H5Web v17 upgrade. I'm fixing an overflow bug, refactoring error boundaries so they are more targeted and predictable, and handling errors propagated from the H5Web viewer a bit better.
After the upgrade, HDF5 errors like the one in the recording below will be properly formatted and the trace will be hidden inside an accordion:
Screencast.from.2026-04-15.17-26-20.webm
I'm also adding a paragraph at the top of the error report email asking people to introduce themselves, so that we have something more to go on that just people's email addresses.