Skip to content

Conversation

@sergey-yaroslavtsev
Copy link
Collaborator

@sergey-yaroslavtsev sergey-yaroslavtsev commented Jul 18, 2025

When click on dataset in the group it adds all datasets to the table. If one dataset is too long it does not fit QSpinBox which leads to fact that any dataset from the group could not be displayed.
Rare and funny bug.
I suggest just to skip such long datasets as one will not "spin" over 2 billion of layers.

Screenshot 2025-07-18 142213

@woutdenolf
Copy link
Collaborator

Can you show me a screenshot of the "spinbox"? I have never seen it. Which window does it appear in?

@vasole
Copy link
Member

vasole commented Jul 18, 2025

I suggest just to skip such long datasets as one will not "spin" over 2 billion of layers.

No, the dataset should not be skept. The user should at least be able to spin over the different dimensions.

If a workaround is needed, instead of setting the maximum to zero, it seems more appropriate to set it to 2^31 -1. The user will still have access to display everything via the dimension spinboxes.

@vasole
Copy link
Member

vasole commented Jul 18, 2025

Something like this:

image

@sergey-yaroslavtsev
Copy link
Collaborator Author

Can you show me a screenshot of the "spinbox"? I have never seen it. Which window does it appear in?

Choose multidimensional dataset and then select "Slice".
image

@sergey-yaroslavtsev
Copy link
Collaborator Author

sergey-yaroslavtsev commented Jul 18, 2025

Something like this:

image

would it be shorter to:

        if maximum and maximum < 2**31-1:
            self._index.setMaximum(min(maximum,2**31-1)  - 1)

@vasole
Copy link
Member

vasole commented Jul 18, 2025

Something like this:
image

would it be shorter to:

        if maximum and maximum < 2**31-1:
            self._index.setMaximum(min(maximum,2**31-1)  - 1)

It should be:

     if maximum:
         self._index.setMaximum(min(maximum, 2**31)  - 1)

but yes, it looks better.

@vasole
Copy link
Member

vasole commented Jul 18, 2025

Please, update the year in first line (replace 2023 by 2025) and it is fine with me.

@sergey-yaroslavtsev sergey-yaroslavtsev merged commit 839f144 into master Jul 28, 2025
6 checks passed
@vasole vasole deleted the skip-too-long-dataset branch November 21, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants