Skip to content

Conversation

@sergey-yaroslavtsev
Copy link
Collaborator

Closes #1157
Just reorder fileTypeList in every place where .h5 or .hdf5 exists.
On the way found few places with .h5, .nxs, .hdf without .hdf5 -> so I've added it to the list.

Copy link
Collaborator

@woutdenolf woutdenolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. To be checked with @vasole

@sergey-yaroslavtsev
Copy link
Collaborator Author

Hmmm some fun behavior in main source selector.
image
Need a correct it is explicitly reorders somewhere. Will do

@vasole
Copy link
Member

vasole commented Dec 12, 2025

For the ROI Imaging Tool it is a no brainer (if the first item in the filter is .edf it does not make sense today).

I am hesitating about the main application window (default extension is mca).

@vasole
Copy link
Member

vasole commented Dec 12, 2025

Need a correct it is explicitly reorders somewhere.

Your comment in issue #1157 about the number of clicks made me think that you might not know that you can customize PyMca's default filedialog, file filter, input directory, user defined counters and so on:

http://www.silx.org/doc/PyMca/latest/customization/settings/index.html

If user has defined mca as the default file filter, it will be used irrespective of your list. If you want to make sure your list is used, you need a fresh start of PyMca or to delete the PyMca.ini file

@sergey-yaroslavtsev
Copy link
Collaborator Author

I am hesitating about the main application window (default extension is mca).

Just from my local experience - many ESRF beamlines use PyMca as data viewer and can open several windows (to navigate through several files at the same time). Since almost every ESRF beamline have Bliss, the .h5 would be logical.
But it could be that I am missing something.

@vasole
Copy link
Member

vasole commented Dec 12, 2025

I am hesitating about the main application window (default extension is mca).

Just from my local experience - many ESRF beamlines use PyMca as data viewer and can open several windows (to navigate through several files at the same time). Since almost every ESRF beamline have Bliss, the .h5 would be logical. But it could be that I am missing something.

Yes because of that I am hesitating about checking if esrf is in the machine domain to make the choice if the user has not specified any default.

@vasole
Copy link
Member

vasole commented Dec 12, 2025

A simple closing of an opened HDF5 file and saving the settings and the default filter is selected. With the benefit that the input directory is also kept.

I do not understand the need to open multiple windows to browse multiple files. It is much more powerful to open all of them in the same instance to compare the data.

@vasole
Copy link
Member

vasole commented Dec 12, 2025

Let's put your default and see if users complain...

@vasole vasole merged commit fc11c61 into master Dec 12, 2025
6 checks passed
@vasole vasole deleted the default_h5 branch December 12, 2025 17:37
@sergey-yaroslavtsev
Copy link
Collaborator Author

I do not understand the need to open multiple windows to browse multiple files. It is much more powerful to open all of them in the same instance to compare the data.

I just saying what I saw 😄 if I remember correctly it was about open old h5 file and a new one to have a look on both

Let's put your default and see if users complain...

Let's try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HDF5 to be default

4 participants