Skip to content

Conversation

@woutdenolf
Copy link
Collaborator

@woutdenolf woutdenolf commented Jan 9, 2026

Restore the intended behavior of the xmin and xmax arguments of McaTheory.setData which was changed in c713a49.

The final xmin and xmax values are defined with this order of priority

  1. If the xmin or xmax function argument is not None: take it.
  2. If use_limits=True and the "xmin" or "xmax" value from the configuration is not None: take it.
  3. If the xdata is not empty: take the min(xdata) or max(xdata) value.
  4. xmin=None or xmax=None (not needed anyway).

@woutdenolf woutdenolf linked an issue Jan 9, 2026 that may be closed by this pull request
@woutdenolf woutdenolf requested a review from vasole January 9, 2026 07:34
vasole

This comment was marked as duplicate.

@vasole
Copy link
Member

vasole commented Jan 9, 2026

Please, review my contributions too!

@woutdenolf
Copy link
Collaborator Author

LGTM for me.

@vasole vasole merged commit 0de55c1 into master Jan 9, 2026
7 checks passed
@vasole vasole deleted the 1171-use_limits-problems-again branch January 9, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use_limits problems again

3 participants