Skip to content

Fix undefined names#1205

Merged
woutdenolf merged 4 commits into
masterfrom
fix_undefined_names
Mar 31, 2026
Merged

Fix undefined names#1205
woutdenolf merged 4 commits into
masterfrom
fix_undefined_names

Conversation

@woutdenolf

@woutdenolf woutdenolf commented Mar 9, 2026

Copy link
Copy Markdown
Collaborator

First commit are fixes after the CLI refactoring related to 'undefined names': #1198

The other commits fix more undefined names found with flake8 --select=F821. I did not fix the ones that had no clear solution.

@woutdenolf woutdenolf force-pushed the fix_undefined_names branch from 49a17fa to 965e98f Compare March 9, 2026 22:16
@woutdenolf woutdenolf force-pushed the fix_undefined_names branch from 965e98f to e119ad7 Compare March 9, 2026 22:23
Comment thread src/PyMca5/PyMcaPhysics/xrf/LegacyFastXRFLinearFit.py
Comment thread src/PyMca5/PyMcaGraph/backends/MatplotlibBackend.py
Comment thread src/PyMca5/PyMcaGui/io/hdf5/HDF5McaTable.py Outdated
Comment thread src/PyMca5/PyMcaMath/mva/PCAModule.py
Comment thread src/PyMca5/PyMcaMath/ImageRegistration.py
Comment thread src/PyMca5/PyMcaMath/linalg.py
@sergey-yaroslavtsev

sergey-yaroslavtsev commented Mar 30, 2026

Copy link
Copy Markdown
Collaborator

I checked - everything seems OK.
However some code which was corrected is actually a "dead" code (see comments) because it goes after "if 0:" or after "return" or after "elif 1: / else:". I do not know if it should be cleaned in this PR or in a different one.

@sergey-yaroslavtsev sergey-yaroslavtsev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contain some "dead" code but it does not affect workability,

@woutdenolf

Copy link
Copy Markdown
Collaborator Author

Contain some "dead" code but it does not affect workability.

Yes the project is full of dead code but I did not introduce the dead code, I fix it because it exists.

@woutdenolf woutdenolf mentioned this pull request Mar 30, 2026
@woutdenolf woutdenolf merged commit 0942438 into master Mar 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants