Fix undefined names#1205
Merged
Merged
Conversation
49a17fa to
965e98f
Compare
965e98f to
e119ad7
Compare
woutdenolf
commented
Mar 9, 2026
Collaborator
|
I checked - everything seems OK. |
sergey-yaroslavtsev
approved these changes
Mar 30, 2026
sergey-yaroslavtsev
left a comment
Collaborator
There was a problem hiding this comment.
Contain some "dead" code but it does not affect workability,
Collaborator
Author
Yes the project is full of dead code but I did not introduce the dead code, I fix it because it exists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit are fixes after the CLI refactoring related to 'undefined names': #1198
The other commits fix more undefined names found with
flake8 --select=F821. I did not fix the ones that had no clear solution.