Skip to content

Messages refactor#471

Merged
Shatur merged 1 commit into
bevy-0.16-devfrom
messages-refactor
Apr 23, 2025
Merged

Messages refactor#471
Shatur merged 1 commit into
bevy-0.16-devfrom
messages-refactor

Conversation

@Shatur
Copy link
Copy Markdown
Contributor

@Shatur Shatur commented Apr 22, 2025

The PR contains only renames. Decided to submit it first to simplify the future relations PR.

  • Rename into Updates and Mutations. Shorter and these components aren't messages. We actually create messages from them.
  • Use shorter methods in Mutations. Things like mutations.add_mutated_entity looks too redundant.
  • In Updates I made few names more explicit since it accumulates not only changes.
  • Use the variable name changes when referring to ChangeRanges.

- Rename into `Updates` and `Mutations`. Shorter and these components
  aren't messages. We actually create messages from them.
- Use shorter methods in `Mutations`. Things like
  `mutations.add_mutated_entity` looks too redundant.
- In `Updates` I made few names more explicit since it accumulates not
  only changes.
- Use the variable name `changes` when referring to `ChangeRanges`.
@Shatur Shatur changed the title Messages-refactor Messages refactor Apr 22, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2025

Codecov Report

Attention: Patch coverage is 78.12500% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (0a7e2a1) to head (0a420f2).
Report is 2 commits behind head on bevy-0.16-dev.

Files with missing lines Patch % Lines
src/server.rs 53.84% 12 Missing ⚠️
src/server/replication_messages/mutations.rs 92.30% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           bevy-0.16-dev     #471      +/-   ##
=================================================
- Coverage          79.87%   79.86%   -0.02%     
=================================================
  Files                 52       52              
  Lines               2768     2766       -2     
=================================================
- Hits                2211     2209       -2     
  Misses               557      557              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Shatur Shatur merged commit bb7ee53 into bevy-0.16-dev Apr 23, 2025
8 checks passed
@Shatur Shatur deleted the messages-refactor branch April 23, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants