Messages refactor#471
Merged
Merged
Conversation
- Rename into `Updates` and `Mutations`. Shorter and these components aren't messages. We actually create messages from them. - Use shorter methods in `Mutations`. Things like `mutations.add_mutated_entity` looks too redundant. - In `Updates` I made few names more explicit since it accumulates not only changes. - Use the variable name `changes` when referring to `ChangeRanges`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## bevy-0.16-dev #471 +/- ##
=================================================
- Coverage 79.87% 79.86% -0.02%
=================================================
Files 52 52
Lines 2768 2766 -2
=================================================
- Hits 2211 2209 -2
Misses 557 557 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UkoeHB
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR contains only renames. Decided to submit it first to simplify the future relations PR.
UpdatesandMutations. Shorter and these components aren't messages. We actually create messages from them.Mutations. Things likemutations.add_mutated_entitylooks too redundant.UpdatesI made few names more explicit since it accumulates not only changes.changeswhen referring toChangeRanges.