Repository navigation
Preserve syntax styles across editor settings changes - #479
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing line numbers, wrapping, or character spacing could briefly clear syntax styles before asynchronous highlighting restored them. Tab-width changes could also leave existing text at the old width until another setting caused reflow.
Layout changes now preserve syntax attributes and pending highlight requests. Kerning and tab stops update only layout attributes; tab-width changes immediately reflow text and refresh content size. Newly created line controllers also inherit configured kerning.
Theme updates keep the displayed styled string until a request-owned replacement is ready, then swap it in atomically. Cancellation, failures, synchronous takeover, obsolete completions, and layout changes during a pending theme update preserve the correct state. Async completion also notifies layout when font height changes without a width change.
Validation: