Skip to content

Add load_with_options: partial loading and per-source failure reporting #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomconroy wants to merge 1 commit into from
Closed

Add load_with_options: partial loading and per-source failure reporting #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion babelfont/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ default = [
]
vfb = ["dep:vfbreader"]
glyphs = ["dep:glyphslib"]
ufo = ["dep:norad"]
ufo = ["dep:norad", "dep:plist"]
fontra = []
robocjk = []
fontlab = []
Expand All @@ -55,6 +55,7 @@ reactive = ["dep:reactive_stores"]
chrono = { version = "0.4.3", features = ["serde"] }
glyphslib = { version = "0.2.6", optional = true }
norad = { version = "0.17.0", features = ["kurbo"], optional = true }
plist = { version = "1", optional = true }

@simoncozens simoncozens Jul 13, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this dependency is actually used?

@tomconroy tomconroy Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in the new ufo::converters::default_layer_glyph_names – added so that we can still output the glyph names without any layers:

// full load                              // load_layers: false
{                                         {
  "name": "A",                              "name": "A",
  "category": "Base",                       "category": "Base"
  "codepoints": [65],                     }
  "layers": [ /* 2 layers */ ]
}

log = { workspace = true }
serde_json = "1.0"
serde = { version = "1.0", features = ["derive"] }
Expand Down
Loading
Loading