fix:lib:Hledger.Query: words'': Parse escaped quotes in quoted patterns #2513
+20
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Seems good! Thank you @TuongNM! |
Contributor
|
I have stopped using hledger some time ago (did not need accounting after all) and apologies for not making up the promise made those years ago about testing this bug. I am so glad that this project is still active and fixing almost 10yr old bugs! What a continuity and what a nice Christmas present :) You people rock! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #649 by parsing the escaped quotes for account 2 and 4 from #649 (comment) that hledger-web produces.
I saw
parseBooleanQueryuse the same code aswords''for quoted patterns so I extracted the functions to reduce code duplication.