Handle the case with month day missing in both start and end data #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yeah, I agree. I would certainly vote for including this in (version 0.8.x of the) spec if anyone suggested that. |
simonpoole
force-pushed
the
catch_missing_monthday_properly
branch
from
1815ff0 to
3dadf5f
Compare
This changes things so that we catch the case when a date range has no month day for both the start and end date (and no interval is specified). It could be argued that it is very silly that the spec doesn't allow this (not to mention the whole separate month range silliness) Resolves #95
simonpoole
force-pushed
the
catch_missing_monthday_properly
branch
from
3dadf5f to
21c3d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes things so that we catch the case when a date range has no month day for both the start and end date (and no interval is specified).
It could be argued that it is very silly that the spec doesn't allow this (not to mention the whole separate month range silliness)
Resolves #95