Skip to content

Allow elevations over 90 degrees for LAT, prevent duplicate parking searches #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mmccrackan
Copy link
Collaborator

@mmccrackan mmccrackan commented May 8, 2025

Branch to start enabling elevations > 90 degrees for the LAT. Also included a minor fix to prevent duplicate azimuths from being searched when finding gap parking.

I kept the elevations_under_90 parameter around just in case we need it in the near term, but we can remove it later if we want. Defaults to False.

@mmccrackan mmccrackan changed the title Allow el_over_90 for LAT, prevent duplicate parking searches Allow elevations over 90 degrees for LAT, prevent duplicate parking searches May 8, 2025
@kmharrington
Copy link
Member

We have some edits to make here. Right now if we run with these parameters:

corotator: Locked
elevations_under_90: False
apply_corotator_rotation: True

We end up commanding the co-rotator up at 80+ degrees which is 100% outside the available range. The issue is that right now we only have the "locked" / boresight=0 setup implemented for the co-rotator. When the elevations are above 90 degrees the intention from the reference plan is to run those in the boresight=180 mode.

I think we need additional logic around here:

if self.corotator_override is not None:

@mmccrackan
Copy link
Collaborator Author

Thank, will fix. Also, yet another sun-safety issue has appeared with this now that we've relaxed the sun-safety parameters. The sun-safety checker actually checks both the start and stop azimuth values and uses the most stringent one for the next move whereas the one inside scheduler does not and only uses the first value, thus giving new failures when elevations_under_90=False. Will also fix.

@mmccrackan
Copy link
Collaborator Author

I updated the corotator angle and boresight angle calculations here to accommodate boresight 180, though I'm not 100% sure the corotator angle sign is correct (I made both branches agree at 90 degrees). Also updated the sun-safety handling so it checks both the start and end of scans now, so I'll mark as ready for a re-review.

@mmccrackan mmccrackan requested a review from kmharrington May 27, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants