Skip to content

Fix segfault in recent wheel builds#215

Merged
tskisner merged 1 commit intomasterfrom
ceres_segfault
Jul 7, 2025
Merged

Fix segfault in recent wheel builds#215
tskisner merged 1 commit intomasterfrom
ceres_segfault

Conversation

@tskisner
Copy link
Copy Markdown
Member

@tskisner tskisner commented Jul 4, 2025

The 0.2.1 tag introduced ceres-solver + Eigen + GLOG into the compiled dependencies and into the wheel building scripts. The resulting wheels, when installed into a conda environment, triggered a segfault inside the conda-forge glog package. I am not sure the cause of this, since the glog library vendored in the so3g wheels should have its name modified to avoid such conflicts.

This work changes the compilation inside the wheels to build and link static versions of glog and ceres-solver. I tested a locally-built (with cibuildwheel) wheel and verified that the segfault is now gone and that sotodlib master branch unit tests pass using this so3g wheel.

The 0.2.1 tag introduced ceres-solver + Eigen + GLOG into the
compiled dependencies and into the wheel building scripts.  The
resulting wheels, when installed into a conda environment,
triggered a segfault inside the conda-forge glog package.  I am
not sure the cause of this, since the glog library vendored in
the so3g wheels should have its name modified to avoid such
conflicts.

This work changes the compilation inside the wheels to build
and link static versions of glog and ceres-solver.  I tested
a locally-built (which cibuildwheel) wheel and verified that
the segfault is now gone and that sotodlib master branch unit
tests pass using this so3g wheel.
@tskisner tskisner requested a review from mhasself July 4, 2025 18:43
@tskisner
Copy link
Copy Markdown
Member Author

tskisner commented Jul 4, 2025

I additionally tested the wheel artifacts from the github CI workflow and the sotodlib unit tests pass with no issues.

@tskisner tskisner merged commit 19e58c0 into master Jul 7, 2025
14 checks passed
@tskisner tskisner deleted the ceres_segfault branch July 7, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants