Conversation
tskisner
previously approved these changes
Sep 23, 2025
Member
tskisner
left a comment
tskisner
left a comment
There was a problem hiding this comment.
Thanks for this fix. The github macos-latest runners on arm64 must have been updated.
This should buy us a few more months of OSX=14 compat for ARM.
mhasself
changed the title
Member
Author
|
(Changed the strategy here to use older image rather than bumping build target.) |
tskisner
approved these changes
Sep 23, 2025
Member
tskisner
left a comment
tskisner
left a comment
There was a problem hiding this comment.
Sure, this looks good. Pinning deployment target to macos-14 means the wheels will also work on older macos installs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.