Skip to content

feat: skip shape check for RangesMatrix math operations #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhasself merged 1 commit into from
Feb 18, 2026
Merged

feat: skip shape check for RangesMatrix math operations #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions python/proj/ranges.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def __getitem__(self, index):

def __add__(self, x):
if isinstance(x, Ranges):
return self.__class__([d + x for d in self.ranges])
return self.__class__([d + x for d in self.ranges], skip_shape_check=True)
elif isinstance(x, RangesMatrix):
# Check for shape compatibility.
nd_a = len(self.shape)
Expand All @@ -122,16 +122,16 @@ def __add__(self, x):
if nd_a == nd_b:
# Broadcast if either has shape 1...
if x.shape[0] == 1:
return self.__class__([r + x[0] for r in self.ranges])
return self.__class__([r + x[0] for r in self.ranges], skip_shape_check=True)
elif self.shape[0] == 1:
return self.__class__([self.ranges[0] + _x for _x in x])
return self.__class__([self.ranges[0] + _x for _x in x], skip_shape_check=True)
elif self.shape[0] == x.shape[0]:
return self.__class__([r + d for r, d in zip(self.ranges, x)])
return self.__class__([r + x for r in self.ranges])
return self.__class__([r + d for r, d in zip(self.ranges, x)], skip_shape_check=True)
return self.__class__([r + x for r in self.ranges], skip_shape_check=True)

def __mul__(self, x):
if isinstance(x, Ranges):
return self.__class__([d * x for d in self.ranges])
return self.__class__([d * x for d in self.ranges], skip_shape_check=True)
elif isinstance(x, RangesMatrix):
# Check for shape compatibility.
nd_a = len(self.shape)
Expand All @@ -144,15 +144,15 @@ def __mul__(self, x):
if nd_a == nd_b:
# Broadcast if either has shape 1...
if x.shape[0] == 1:
return self.__class__([r * x[0] for r in self.ranges])
return self.__class__([r * x[0] for r in self.ranges], skip_shape_check=True)
elif self.shape[0] == 1:
return self.__class__([self.ranges[0] * _x for _x in x])
return self.__class__([self.ranges[0] * _x for _x in x], skip_shape_check=True)
elif self.shape[0] == x.shape[0]:
return self.__class__([r * d for r, d in zip(self.ranges, x)])
return self.__class__([r * x for r in self.ranges])
return self.__class__([r * d for r, d in zip(self.ranges, x)], skip_shape_check=True)
return self.__class__([r * x for r in self.ranges], skip_shape_check=True)

def __invert__(self):
return self.__class__([~x for x in self.ranges])
return self.__class__([~x for x in self.ranges], skip_shape_check=True)

@staticmethod
def concatenate(items, axis=0):
Expand Down