Adding subscan HWPSS subtraction function to sotodlib.hwp.hwp #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykyohei
reviewed
Jan 21, 2025
ykyohei
reviewed
Jan 21, 2025
ykyohei
requested changes
Jan 21, 2025
There was a problem hiding this comment.
General comments.
- I think this function should be merged to
get_hwpsswithiterationoption andsubscanoption, but maybe I should ask other reviewer's opinions. - logger.info seems not necessary, please make them inline comments
- Please run linter such as flake8 and make corrections
- We also need to correction in docstring. this can be done in the next iteration.
Merged
ykyohei
reviewed
Feb 21, 2025
There was a problem hiding this comment.
The hwpss_model in this method has an inherent discontinuity in the boundaries of the subscans. This leads to 0.1 aW level of ringing at the boundaries of subscans. This is below single detector white noise level 25-40 aW rt(s) but it can matter when we coadd data. We need to smooth the model to avoid masking the turnarounds too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function in hwp.py to complete HWPSS subtraction by subscan, accounting for amplitude and phase variation within each scan and not relying on mean subtraction post-demodulation. It has also been found that glitch detection after HWPSS subtraction is more effective for identifying glitches, and this function introduces an iterative glitch detection approach, which also reduces bias in the HWPSS fit by improving the glitch mask.