Uhf labels #1146
Open
Uhf labels #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to check with @smsimon and @keskitalo that this won't be a breaking change for the sims. But we've confirmed these will be the names that come out of the real data |
|
There are a lot of references to these elsewhere. The proposal we had within DM was to keep the labels in the sims the same and just have the sim and data labels be different. |
|
There are f290/f230 UHF labels in pwg-scripts as well... https://github.com/search?q=repo%3Asimonsobs%2Fpwg-scripts%20f290&type=code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f230/290 changed to f220/280 to match data labels.