-
Notifications
You must be signed in to change notification settings - Fork 19
load_book: support for fixed tones, smurfgaps flags, no_headers #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- When "special_channel=True" is passed to get_obs, the "untracked" channels are loaded and populate a .tones sub-AxisMan. - The smurfgaps flags are loaded from the per-stream frame data and put into `.flags.smurfgaps_{stream_id}`. - When user passes "no_headers=True", the smurf header fields will not be unpacked (so there is no .primary).
Addresses #1160. Here's what smurfgaps looks like (obs_id='obs_1745071718_satp1_1111111')
|
Also addresses #1190. E.g:
Then:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Any chance there's a way to make operations books automatically load headers but not obs books? I suspect we'll usually want it when operation books are being loaded.
Yes... this seems to be quite a big savings, so it's in place now. At least when you use I had assumed that loading headers was cheap, if one were already loading signal. But looks like that's not the case ... my random test suggests 40% increase in load time, when reading headers. I cleaned up a couple other things. Will merge when tests pass unless there are further concerns. |
.flags.smurfgaps_{stream_id}
.