Skip to content

feat: add more flexibility when inserting default iir params #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Conversation

skhrg
Copy link
Member

@skhrg skhrg commented May 13, 2025

No description provided.

@skhrg skhrg requested review from ykyohei and msilvafe May 13, 2025 17:49
Copy link
Contributor

@msilvafe msilvafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with these changes although I would prefer that in addition to adding these optional arguments you add the known time range for the lat to the time_range dictionary. I also think a simple extension of this is to allow the time_range dictionary to contain a list of tuples of start/end times and loop over that list to allow for multiple epochs. The latter you don't need to implement but I would like you to implement the former.

@skhrg
Copy link
Member Author

skhrg commented May 13, 2025

Yeah having some known time ranges would be good. I don't currently have them recorded in a convenient way. @mmccrackan you have a list of bad obs right? Do you have ranges you recommend?

@mmccrackan
Copy link
Contributor

Yeah having some known time ranges would be good. I don't currently have them recorded in a convenient way. @mmccrackan you have a list of bad obs right? Do you have ranges you recommend?

I only know it started after 04/25 and no Mars observations were missing them before that. It is not only Mars observations, but I also saw some rcw38 that are missing them as well. I will run a script to get a complete list of the ones with missing values.

@mmccrackan
Copy link
Contributor

mmccrackan commented May 13, 2025

20250513_iir_stats.txt

Here's the full list of obs_ids, wafers, and ufms for the query.

'type="obs" and start_time > 1745452800'
With 1745452800 being April 24th. It looks like the range is between 1745970733 and 1746624934.

@msilvafe
Copy link
Contributor

20250513_iir_stats.txt

Here's the full list of obs_ids, wafers, and ufms for the query.

'type="obs" and start_time > 1745452800' With 1745452800 being April 24th. It looks like the range is between 1745970733 and 1746624934.

Confirm that the end date is around when I slacked @tpsatt about hard hammering to reset these.

@skhrg skhrg requested a review from msilvafe May 22, 2025 14:34
@skhrg
Copy link
Member Author

skhrg commented May 22, 2025

Okay @msilvafe I think I got those changes in. Let me know if it looks okay to merge.

Copy link
Contributor

@ykyohei ykyohei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lat time_ranges has typo. Other points look good to me.

@skhrg
Copy link
Member Author

skhrg commented May 22, 2025

Good catch! Fixed

@skhrg skhrg merged commit ac722ac into master May 22, 2025
5 checks passed
@skhrg skhrg deleted the iir_force branch May 22, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants