Skip to content

Common mode glitch #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

Common mode glitch #1229

merged 3 commits into from
May 29, 2025

Conversation

ykyohei
Copy link
Contributor

@ykyohei ykyohei commented May 21, 2025

Modified get_glitch_flags to allow 1d array input and added preprocess for getting common mode. Also added unit test.

The motivation is to find and remove the glitch which is common among detectors. We have physical motivation for this kind of glitches. We can also do this on hwp demodulated timestreams to find the glitch induced by hwp angle.

Example preprocess config for common mode glitch.

    - name: "get_common_mode"
      calc:
        signal: "signal"
        method: "median"
        wrap: "signal_commonmode"
      save: True

    - name: "glitches"
      skip_on_sim: False
      glitch_name: "glitches_commonmode"
      calc:
        signal_name: 'signal_commonmode'
        t_glitch: 0.007
        buffer: 100
        hp_fc: 6.0
        n_sig: 10
      save: True

@ykyohei ykyohei marked this pull request as ready for review May 21, 2025 18:33
@ykyohei ykyohei requested a review from msilvafe May 28, 2025 19:50
Copy link
Contributor

@msilvafe msilvafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me what testing have you done other than the unit tests?

@ykyohei
Copy link
Contributor Author

ykyohei commented May 29, 2025

Thanks. Another test I did was to make sure the example preprocess config runs as expected.
I found minor typo, so let me fix it and merge this.

@ykyohei ykyohei merged commit 414d68a into master May 29, 2025
5 checks passed
@ykyohei ykyohei deleted the common_mode_glitch branch May 29, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants