Changes needed to work with new so3g#1591
Merged
Conversation
These changes are designed to allow sotodlib to pass unit tests with both the legacy so3g / spt3g as well as current spt3g plus the in-development version of so3g which uses pybind11 instead of boost. This PR just enables the passing of unit tests, which do not test the creation and loading of books. In particular, the book binding code and all other uses of G3SuperTimestream need to be updated before we can use the new so3g.
iparask
reviewed
Mar 26, 2026
Comment on lines
+12
to
+15
| if hasattr(so3g.proj.quat, "quat"): | ||
| legacy_spt3g = True | ||
| else: | ||
| legacy_spt3g = False |
Member
There was a problem hiding this comment.
Why not mask so3g.proj.quat.quat and so3g.proj.quat.Quat here so that you do not have to check if it is legacy or not every time it is called?
For example:
if hasattr(so3g.proj.quat, "quat"):
legacy_spt3g = True
quat = so3g.proj.quat.quat
else:
legacy_spt3g = False
quat = so3g.proj.quat.Quat
Member
Author
There was a problem hiding this comment.
Thanks, I simplified this and removed the legacy_spt3g bool, which is not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are designed to allow sotodlib to pass unit tests with both the legacy so3g / spt3g as well as current spt3g plus the in-development version of so3g which uses pybind11 instead of boost.
This PR just enables the passing of unit tests, which do not test the creation and loading of books. In particular, the book binding code and all other uses of G3SuperTimestream need to be updated before we can use the new so3g.
I verified that this branch works both with the latest release of so3g and also the code in simonsobs/so3g#229