README: minimum Python is 3.10, not 3.8 - #2878
Open
melbinjp wants to merge 1 commit into
Open
Conversation
requires-python has been ">=3.10" since ce4b079, and the 0.65 release notes (2024-10-07) say "Dropped support for Python 3.8". The README still tells users 3.8 works; on 3.8 or 3.9 pip refuses to install datasette.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README's installation section still says:
but the actual floor is 3.10:
pyproject.tomlhasrequires-python = ">=3.10"(set in ce4b079)docs/contributing.rstalready says "If you have Python 3.10 or higher"A user on 3.8 or 3.9 who follows the README gets pip's
Requires-Pythonrefusal at install time. One-word fix; no other live doc makes the 3.8 claim (the changelog mentions are history and correct as written).Found with docproof, which checks what documentation claims against what the repository actually contains.