Allow TreeMesh.__repr__ to run when non finalized
#393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `TreeMesh.__repr__` and `TreeMesh._repr_html_` to run even when the mesh has not been finalized yet. This avoid an error to be raised, and provides minimal information about the mesh extent.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 86.21% 86.57% +0.35%
==========================================
Files 90 90
Lines 18625 18669 +44
Branches 2103 2109 +6
==========================================
+ Hits 16058 16163 +105
+ Misses 1883 1822 -61
Partials 684 684 ☔ View full report in Codecov by Sentry. |
santisoler
commented
Feb 21, 2025
santisoler
commented
Feb 21, 2025
santisoler
commented
Feb 24, 2025
santisoler
commented
Feb 24, 2025
santisoler
commented
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
TreeMesh.__repr__andTreeMesh._repr_html_to run even when the mesh has not been finalized yet. This avoid an error to be raised, and provides minimal information about the mesh extent. Test if the methods don't error out when the mesh is not finalized.Related to #392