Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important background: Monotonic time is the "correct" way to calculate elapsed time in Ruby:
https://blog.dnsimple.com/2018/03/elapsed-time-with-ruby-the-right-way/
started_at
based on the monotonic clock which is guaranteed to always move forward (processor uptime)created_at
/timestamp
based onProcess.clock_gettime(Process::CLOCK_REALTIME)
, to avoidTime.now
stubbing & Timecop issuesI do not understand the rubocop failure in CI, because when I run locally there are no violations:
Same result when run with
bundle exec rake rubocop
as it is in CI.CC @ilyazub