Open
Conversation
added 9 commits
September 17, 2020 09:25
should translate legacy address format to cashaddr format correctly
add regtest address test case
regtest address support
add slp regtest address
…re/regtest-address * 'master' of github.com:simpleledger/bchaddrjs: d.ts update add d.ts file
|
Thanks for submitting the PR. I don't understand why we need to add the "regtest" parameter in many of the methods. I use this library with the regtest network as-is. For example: Can you please explain why these changes are needed and what can't be achieved as-is? |
Author
|
@jcramer Because many methods requires regtest flag to discern between regtest and testnet address |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add regtest support