Skip to content

Comments

September 12th 2025 Cohort#20

Open
hemalvarambhia wants to merge 84 commits intomainfrom
2025-09-12-cohort
Open

September 12th 2025 Cohort#20
hemalvarambhia wants to merge 84 commits intomainfrom
2025-09-12-cohort

Conversation

@hemalvarambhia
Copy link
Contributor

@hemalvarambhia hemalvarambhia commented Oct 13, 2025

No description provided.

hemalvarambhia and others added 30 commits September 12, 2025 15:01
@hemalvarambhia
chore: update ruby.
1872fe7
@hemalvarambhia
chore: added a item to my test list.
9a1b183
@crubiov
Added new test case for checking direction
f066a5f
@daviddobbie840
Add test for missing starting point
d3144cb
@sb-william
direction pending test
c8407ce
@hemalvarambhia
chore: added another edge case test.
d5b1a3b
@hemalvarambhia
failing: added our first failing test.
03efe99
@crubiov
faling: added an initialize method
475764e
@daviddobbie840
fix: passing position test with hack
7c33e1a
@hemalvarambhia
refactor: inverted a dependency.
8925d01
@hemalvarambhia
refactor: rename field as the position is always current.
71a8290
@hemalvarambhia
refactor: have the method return the instance variable.
3843349
@hemalvarambhia
refactor: added the attr_reader as the idiomatic for reader method.
7e23ab0
@hemalvarambhia
refactor: removed the obsolete reader method.
e54c36b
@hemalvarambhia
feat: a Mars Rover can have a starting position anywhere on Mars.
382733b
@hemalvarambhia
chore: inbox markdown for ideas.
32d4fb4
@crubiov
refactor: parameterise tests for position.
b233b18
@crubiov
refactor: removed obsolete test for position.
66c1142
@daviddobbie840
feat: added direction to Mars Rover
a79cc5f
@daviddobbie840
feat: added default starting position to MarsRover
abbfd13
@hemalvarambhia
refactor: pushed a detail (default setting up towards the tests) up t…
d3d7512 
…he call stack.
@hemalvarambhia
refactor: removed obsolete code.
fe77d1f
@hemalvarambhia
refactor: declared just one attr_reader.
7e3e603
@daviddobbie840
test: added test that checked invalid direction character
2bc748b
@daviddobbie840
feat: added error checking for direction value
8d24238
@daviddobbie840
feat: changed default value for direction in initialize
3dfe65e
@daviddobbie840
test: changed direction to be tested.
3ea415c
@daviddobbie840
test: fixed test when raising errors.
13b3131
@daviddobbie840
chore: removed invalid direction comment in test
d522334
@daviddobbie840
test: added test that complains if no direction given
9bcb198
daviddobbie840 and others added 29 commits September 26, 2025 15:28
@daviddobbie840
feat: mars rover can move forward when facing west
5957380
@daviddobbie840
refactor: moved move_forward logic to own method
a2feb48
@hemalvarambhia
refactor: copied class to a more sensible place so that it's reusable.
51ae55f
@hemalvarambhia
refactor: removed obsolete code.
4f9021f
@hemalvarambhia
refactor: introduced the concept of coordinates.
1b56073
@hemalvarambhia
refactor: migrated north to also change current coordinates.
fd06647
@hemalvarambhia
refactor: migrated north to also change current coordinates.
f80538e
@hemalvarambhia
refactor: migrated south to also change current coordinates.
3b4dba1
@hemalvarambhia
refactor: migrated west to also change current coordinates.
e6b894c
@crubiov
refactor: migrated the x coordinate to use current_coordinates.
b273387
@crubiov
refactor: migrated the y coordinate to use current_coordinates.
ff2cd44
@crubiov
removed the current_position implementation from moving forward.
54ed5d7
@crubiov
added new attr_reader for current coordinates.
adbfd8a
@crubiov
test: changed from current position to current coordinates in first t…
34ae640 
…est.
@crubiov
refactor: changed the test to use coordinates instead of position.
a40e56e
@daviddobbie840
refactor: moved rest of coordinates array in test to use object
f3a86a3
@daviddobbie840
refactor: removed obsolete positions test array
7eb96ad
@daviddobbie840
refactor: use starting_coordinates in init arg
540c976
@daviddobbie840
refactor: removed obsolete current_position field
93fc66c
@daviddobbie840
refactor: changed current direction test to use coordinate object
c7e26db
@daviddobbie840
refactor: added starting_coordinates arg to other tests
3928fdd
@daviddobbie840
refactor: added coordinates object to mars rover moving tests
d21668f
@daviddobbie840
refactor: removed default positions and coordinates from mars rover
6b3dbe4
@daviddobbie840
refactor: removed obsolete starting_position argument from tests
92a4d81
@daviddobbie840
refactor: removed obsolete starting_postion mars_rover argument
64906b2
@daviddobbie840
chore: added reek gem for development
d65cd44
@hemalvarambhia
chore: added simplycop to adhere to style at SB.
13ad1d7
@hemalvarambhia
fix: accepted upstream changes.
9be11f8
@hemalvarambhia
test: removed a test and corrected another.
375411c
@hemalvarambhia hemalvarambhia changed the title 2025 09 12 cohort September 12th 2025 Cohort Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hemalvarambhia @crubiov @daviddobbie840 @sb-william