Open
Conversation
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
| end | ||
|
|
||
| def execute | ||
| case @current_direction |
There was a problem hiding this comment.
Codacy found an issue: Use 2 (not -2) spaces for indentation.
|
|
||
| def initialize(starting_point:, starting_direction:, commands: []) | ||
| raise ArgumentError, 'The starting direction must be one of N, E, S or W' unless ['N', 'E', 'S', 'W'].include? starting_direction | ||
| raise ArgumentError, 'The starting point cannot be nil' if starting_point.nil? |
There was a problem hiding this comment.
Codacy found an issue: Add empty line after guard clause.
| @@ -0,0 +1,127 @@ | |||
| describe 'Mars Rover' do | |||
| class MarsRover | |||
There was a problem hiding this comment.
Codacy found an issue: Stub class constant instead of declaring explicitly.
| when 'W' | ||
| @current_position = [x_coordinate - 1, y_coordinate] | ||
| end | ||
| end |
There was a problem hiding this comment.
Codacy found an issue: end at 24, 0 is not aligned with def at 13, 4.
| expect { MarsRover.new(starting_point: [-3, 1], starting_direction: ['N', 'E', 'S', 'W']) }.to( | ||
| raise_error(ArgumentError, 'The starting direction must be one of N, E, S or W') | ||
| ) | ||
| end |
There was a problem hiding this comment.
Codacy found an issue: Add an empty line after it.
| @@ -0,0 +1,127 @@ | |||
| describe 'Mars Rover' do | |||
| class MarsRover | |||
There was a problem hiding this comment.
Codacy found an issue: Do not define constants this way within a block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.