feat: expose Android text cursor metadata#3
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16a86beae9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| text_selection_start=node.text_selection_start, | ||
| text_selection_end=node.text_selection_end, |
There was a problem hiding this comment.
accessibility_node_to_ui_element now copies node.text_selection_start/end directly, but for proto3 scalar fields an unset value is indistinguishable from 0. This causes most nodes (including non-editable ones) to appear as if they have a cursor/selection at offset 0, which can mislead any downstream logic that interprets non-None selection metadata as real cursor state. Please apply the same default-handling logic used in _selection_attrs (or equivalent presence checks) before populating these fields.
Useful? React with 👍 / 👎.
simplyme0823
force-pushed
the
feat/cursor
branch
7 times, most recently
from
7d8b801 to
17cd23e
Compare
1 participant
No description provided.