Skip to content

Conversation

@darkliyznyanlin910
Copy link

Summary

Bug fix in Workflow Executor Tool

Fixes #(issue)

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

How has this been tested? What should reviewers focus on?

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

@vercel
Copy link

vercel bot commented Nov 18, 2025

@darkliyznyanlin910 is attempting to deploy a commit to the Sim Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 18, 2025

Greptile Summary

  • Updates workflow executor tool URL from static /api/tools/workflow-executor to dynamic /api/workflows/{workflowId}/execute endpoint
  • Shifts architecture from generic tool endpoint to RESTful resource-based endpoint using workflow ID in URL path

Important Files Changed

Filename Overview
apps/sim/tools/workflow/executor.ts Updated URL construction to use parameterized path with workflowId instead of static endpoint

Confidence score: 3/5

  • This PR requires careful review as it represents a breaking change in API endpoint structure
  • Score reflects potential integration issues if backend routes haven't been updated to match, and concerns about cascading effects on dependent systems
  • Pay close attention to apps/sim/tools/workflow/executor.ts and verify corresponding backend API routes exist

Sequence Diagram

sequenceDiagram
    participant User
    participant WorkflowExecutorTool
    participant API
    participant ChildWorkflow
    participant Logger

    User->>WorkflowExecutorTool: "Execute workflow with workflowId and inputMapping"
    WorkflowExecutorTool->>API: "POST /api/workflows/{workflowId}/execute"
    API->>ChildWorkflow: "Execute child workflow"
    ChildWorkflow->>API: "Return execution results"
    API->>WorkflowExecutorTool: "Response with success, duration, childWorkflowId"
    WorkflowExecutorTool->>Logger: "Log workflow executor response"
    WorkflowExecutorTool->>User: "Return transformed response with execution details"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant