improvement(copilot): v0.2 #2086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix template details * Fix deps
… consistent, smoothen out creation of profile (#1943) * fix(templates): view current ui * update UI to be less cluttered * make state management for creating user profile smoother * fix autoselect logic * fix lint
…ng (#1945) * fix(settings): fix broken api keys, help modal, logs, workflow renaming * fix build * cleanup * use emcn
… drag event directly (#1951)
* new gifs * changed wording * changed wording * lowercase * changed wording * remove blog stuff --------- Co-authored-by: aadamgough <[email protected]> Co-authored-by: waleed <[email protected]>
* feat(drizzle): added ods for analytics from drizzle * clean
* feat(docs): added docs analytics drizzle ods * fix build
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR introduces copilot v0.2 with significant architectural improvements to workflow editing and new capabilities for deployment and navigation. The changes center around a refactored diff system that now tracks baseline workflows separately from proposed changes, enabling better undo/redo integration. Key Changes
Architecture ImprovementsThe workflow diff engine now properly isolates baseline state from proposed changes, allowing copilot edits to be applied, previewed, accepted, or rejected without corrupting the undo/redo stack. The new Issues Found
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant CopilotUI as Copilot UI
participant CopilotStore as Copilot Store
participant Tool as Client Tool
participant DiffStore as Workflow Diff Store
participant WorkflowStore as Workflow Store
participant UndoRedo as Undo/Redo Store
participant API as Backend API
User->>CopilotUI: Send message with mode (ask/build/plan)
CopilotUI->>API: POST /api/copilot/chat
API-->>CopilotStore: SSE stream (tool_call events)
alt Tool Call: edit_workflow
CopilotStore->>Tool: Instantiate EditWorkflowClientTool
Tool->>API: Execute edit_workflow with operations
API-->>Tool: Return proposed WorkflowState
Tool->>DiffStore: setProposedChanges(proposedState)
DiffStore->>DiffStore: Capture baseline snapshot
DiffStore->>WorkflowStore: Apply diff markers to blocks
DiffStore-->>CopilotUI: Show diff preview
alt User accepts changes
User->>Tool: Click Accept
Tool->>DiffStore: acceptChanges()
DiffStore->>UndoRedo: runWithUndoRedoRecordingSuspended
DiffStore->>WorkflowStore: replaceWorkflowState(cleanState)
DiffStore->>API: PUT /api/workflows/{id}/state
DiffStore->>DiffStore: clearDiff()
DiffStore-->>CopilotUI: Hide diff preview
else User rejects changes
User->>Tool: Click Reject
Tool->>DiffStore: rejectChanges()
DiffStore->>UndoRedo: runWithUndoRedoRecordingSuspended
DiffStore->>WorkflowStore: replaceWorkflowState(baseline)
DiffStore->>DiffStore: clearDiff()
DiffStore-->>CopilotUI: Hide diff preview
end
end
alt Tool Call: deploy_workflow
CopilotStore->>Tool: Instantiate DeployWorkflowClientTool
Tool->>API: Check API keys
alt Has API keys
Tool->>API: POST /api/workflows/{id}/deploy
API-->>Tool: Deployment success + endpoint
Tool->>WorkflowStore: Update deployment status
Tool-->>CopilotUI: Show curl command
else No API keys
Tool->>CopilotUI: Open API keys modal
Tool-->>CopilotUI: Show "needs API key" message
end
end
alt Tool Call: navigate_ui
CopilotStore->>Tool: Instantiate NavigateUIClientTool
User->>Tool: Click Accept (Open)
Tool->>Tool: Resolve destination URL
Tool->>User: window.location.href = url
end
alt Undo/Redo Operations
User->>UndoRedo: Trigger undo
UndoRedo->>UndoRedo: Check if recording suspended
UndoRedo->>WorkflowStore: replaceWorkflowState(previousState)
UndoRedo->>API: Queue replaceWorkflowState operation
end
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| // Navigate if URL was set | ||
| if (navigationUrl) { | ||
| window.location.href = navigationUrl |
Contributor
There was a problem hiding this comment.
logic: using window.location.href causes full page reload, losing client-side state and causing jarring UX
Suggested change
| window.location.href = navigationUrl | |
| window.history.pushState({}, '', navigationUrl) | |
| window.dispatchEvent(new PopStateEvent('popstate')) |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/lib/copilot/tools/client/navigation/navigate-ui.ts
Line: 207:207
Comment:
**logic:** using `window.location.href` causes full page reload, losing client-side state and causing jarring UX
```suggestion
window.history.pushState({}, '', navigationUrl)
window.dispatchEvent(new PopStateEvent('popstate'))
```
How can I resolve this? If you propose a fix, please make it concise.| edgeCount: affectedEdges?.length || 0, | ||
| }) | ||
| }, | ||
| [activeWorkflowId, userId, undoRedoStore] |
Contributor
There was a problem hiding this comment.
syntax: changed from sync to async without updating return type in signature, could cause issues for callers expecting synchronous behavior
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/hooks/use-undo-redo.ts
Line: 328:328
Comment:
**syntax:** changed from sync to async without updating return type in signature, could cause issues for callers expecting synchronous behavior
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+26
to
+33
| function cloneWorkflowState(state: WorkflowState): WorkflowState { | ||
| return { | ||
| ...state, | ||
| blocks: structuredClone(state.blocks || {}), | ||
| edges: structuredClone(state.edges || []), | ||
| loops: structuredClone(state.loops || {}), | ||
| parallels: structuredClone(state.parallels || {}), | ||
| } |
Contributor
There was a problem hiding this comment.
logic: using structuredClone can fail on complex objects with functions, symbols, or DOM nodes (common in workflow blocks with callbacks)
Suggested change
| function cloneWorkflowState(state: WorkflowState): WorkflowState { | |
| return { | |
| ...state, | |
| blocks: structuredClone(state.blocks || {}), | |
| edges: structuredClone(state.edges || []), | |
| loops: structuredClone(state.loops || {}), | |
| parallels: structuredClone(state.parallels || {}), | |
| } | |
| function cloneWorkflowState(state: WorkflowState): WorkflowState { | |
| return JSON.parse(JSON.stringify({ | |
| ...state, | |
| blocks: state.blocks || {}, | |
| edges: state.edges || [], | |
| loops: state.loops || {}, | |
| parallels: state.parallels || {}, | |
| })) | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/stores/workflow-diff/store.ts
Line: 26:33
Comment:
**logic:** using `structuredClone` can fail on complex objects with functions, symbols, or DOM nodes (common in workflow blocks with callbacks)
```suggestion
function cloneWorkflowState(state: WorkflowState): WorkflowState {
return JSON.parse(JSON.stringify({
...state,
blocks: state.blocks || {},
edges: state.edges || [],
loops: state.loops || {},
parallels: state.parallels || {},
}))
}
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+44
to
+50
| private getSanitizedWorkflowJson(workflowState: any): string | undefined { | ||
| const logger = createLogger('EditWorkflowClientTool') | ||
|
|
||
| if (!this.workflowId) { | ||
| logger.warn('No workflowId available for getting sanitized workflow JSON') | ||
| return undefined | ||
| } |
Contributor
There was a problem hiding this comment.
style: returning undefined without error handling means silent failures won't be surfaced to copilot, making debugging difficult
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/lib/copilot/tools/client/workflow/edit-workflow.ts
Line: 44:50
Comment:
**style:** returning `undefined` without error handling means silent failures won't be surfaced to copilot, making debugging difficult
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
481
to
+549
| <div className='px-[10px] py-[8px]'> | ||
| <span className='font-mono text-muted-foreground text-xs'> | ||
| {method || 'GET'} | ||
| </span> | ||
| <input | ||
| type='text' | ||
| value={method || 'GET'} | ||
| onChange={(e) => setEditedParams({ ...editedParams, method: e.target.value })} | ||
| className='w-full bg-transparent font-mono text-muted-foreground text-xs outline-none focus:text-foreground' | ||
| /> |
Contributor
There was a problem hiding this comment.
style: editing method directly without validation allows invalid HTTP methods like "GETT" or "post" (lowercase)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/components/copilot/components/inline-tool-call/inline-tool-call.tsx
Line: 543:549
Comment:
**style:** editing method directly without validation allows invalid HTTP methods like "GETT" or "post" (lowercase)
How can I resolve this? If you propose a fix, please make it concise.
This was referenced Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New copilot version: improves existing tools, adds new copilot tools, improves diff store interactions
Type of Change
Testing
Manual
Checklist