Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • remove unused oauth providers from list of supported integrations

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Nov 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Nov 21, 2025 4:19am

@waleedlatif1 waleedlatif1 merged commit 67bd5bd into staging Nov 21, 2025
4 of 5 checks passed
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 21, 2025

Greptile Overview

Greptile Summary

Removed Discord and Supabase from OAuth provider configurations since they authenticate via bot tokens and API keys respectively, not OAuth flows.

The changes correctly comment out:

  • Import statements for DiscordIcon and SupabaseIcon
  • Type definitions in OAuthProvider and OAuthService unions
  • Provider configurations in the OAUTH_PROVIDERS object
  • Authentication config cases in getProviderAuthConfig() function

The Discord and Supabase integrations remain fully functional through their respective blocks (DiscordBlock uses AuthMode.BotToken, SupabaseBlock uses AuthMode.ApiKey), so this change only removes them from the OAuth-specific configuration where they don't belong.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal, targeted, and correct. Discord and Supabase were incorrectly listed as OAuth providers when they actually use simpler authentication methods (bot tokens and API keys). The removal is clean - all related code is commented out consistently, and the actual Discord/Supabase functionality remains intact through their dedicated blocks that use the appropriate auth modes.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/lib/oauth/oauth.ts 5/5 Correctly commented out Discord and Supabase OAuth providers since they use bot tokens/API keys instead of OAuth

Sequence Diagram

sequenceDiagram
    participant User
    participant OAuth Config
    participant Discord Block
    participant Supabase Block
    
    Note over OAuth Config: Before: Discord & Supabase<br/>listed as OAuth providers
    
    User->>OAuth Config: Remove Discord/Supabase from OAuth types
    OAuth Config-->>OAuth Config: Comment out DiscordIcon import
    OAuth Config-->>OAuth Config: Comment out SupabaseIcon import
    OAuth Config-->>OAuth Config: Comment out type definitions
    OAuth Config-->>OAuth Config: Comment out OAUTH_PROVIDERS entries
    OAuth Config-->>OAuth Config: Comment out getProviderAuthConfig cases
    
    Note over OAuth Config: After: No OAuth config for<br/>Discord & Supabase
    Note over Discord Block,Supabase Block: Integrations still work via<br/>AuthMode.BotToken & AuthMode.ApiKey
    
    User->>Discord Block: Use Discord with bot token
    Discord Block-->>User: Works (uses AuthMode.BotToken)
    
    User->>Supabase Block: Use Supabase with API key
    Supabase Block-->>User: Works (uses AuthMode.ApiKey)
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants