Conversation
…functionality in fshelper
…dant MkdirAll calls
…t album associations
…hotos integration
…ance filter handling
…line flag management
…nd add Google Photos archive
…specific namespace: xmlns:immichgo="http://ns.immich-go.com/immich-go/1.0/"
… in a structured folder format
…upload and archive operations
…or filtering and enhance asset structure with rating and tag support
… for tag extraction and serialization
…ssetByID to GetAssetInfo, add DownloadAsset method, and improve request handling for album retrieval
feat: integrate BulkTagManager for improved asset tag management
* Fix typo in variable name and related logic * Update MacOS resource file exclusion pattern
* fix: correct typo in bulkBatchSize constant name in BulkTagManager * fix 0.23.0-RC9 eventually hanging #646: enhance metadata handling for immich-go exports in parseDir method * Merge branch 'next' into simulot/issue638 * fix: tags root/tag * Add caching for tag IDs to reduce upsert calls - Introduce new SyncMap for tag IDs - Modify upsert logic to check cache first - Update tests to verify upsert count - Adjust mock client to track upsert calls - Ensure assets are tagged correctly * Refactor asset upload and replace logic to use a callValues map for better tracing - Introduce callValues map for asset metadata - Simplify field writing in multipart form - Remove redundant file stat calls - Update trace logging for callValues - Clean up unused context keys
- Extract common logic into uploadAsset method - Remove redundant dryRun checks - Simplify AssetUpload and ReplaceAsset methods - Add new endpoint constants for upload and replace - Remove unused constants and functions
* fix: #652 Add support for supplemental-metadata.json files in Google Photos matcher
* Refactor uploadAsset and writeFilePart methods for improved file handling * fix: #662 XMP not uploaded * remove debug code
Refactor GoogleMetaData album check and enhance tests for enriched albums
Takeout-changes
fix up line 361
simulot
added a commit
that referenced
this pull request
Oct 5, 2025
* Remove commented-out code related to Google Photos analysis in upload command * Remove commented-out code related to Google Photos analysis in upload command * Merge branch 'next' into archive * Rename Adapter interface to Reader and update references in upload command * Merge branch 'next' into archive * Add AssetWriter interface and implement context-aware asset writing * Refactor LocalAssetWriter to use fs.FS directly and enhance MkdirAll functionality in fshelper * Enhance LocalAssetWriter to track created directories and avoid redundant MkdirAll calls * Add XMP reading and writing functionality with GPS and time conversion * Add album support to Asset and XMP reading/writing functionality * Refactor OpenFile function to return WFile interface for enhanced write capabilities * Add WriteGroup method to AssetWriter and enhance WriteAsset to support album associations * Add album association to assets and enhance import flags for Google Photos integration * Refactor upload command options to streamline flag management and enhance filter handling * Refactor import command to enhance folder options handling and streamline flag management * Refactor upload and archive commands to streamline options handling and add Google Photos archive * Rename Stars field to Rating in Asset struct for clarity * Refactor XMP read and write to write immich image properties using a specific namespace: xmlns:immichgo="http://ns.immich-go.com/immich-go/1.0/" * Enhance XMP file handling in folder read/write operations to support sidecar files * Edit release.md: Add new `archive` command to store photos and videos in a structured folder format * Refactor command flag handling to include parent command context for upload and archive operations * Add job management endpoints and tag handling functionality, thx to benjamonnguyen * Refactor asset retrieval and tagging: Introduce SearchMetadataQuery for filtering and enhance asset structure with rating and tag support * Add Tags support to Asset structure and introduce Tag type for asset tagging * Add FromImmich adapter with flags for asset retrieval and filtering * Refactor client initialization and add FromImmich command for archiving * Add support for tags in XMP asset handling: enhance reader and writer for tag extraction and serialization * Refactor ImmichClient methods and enhance asset handling: rename GetAssetByID to GetAssetInfo, add DownloadAsset method, and improve request handling for album retrieval * Add immichfs package for reading assets from Immich server with file system interface * Refactor FromImmich adapter: enhance asset filtering, and improve error handling * Add support for tags in XMP asset handling: update reader and writer, and add test cases for tag extraction * Enhance client error handling: ensure client opens successfully and manage API trace writer closure * Add Tagged event type to file events: update constants and string mapping * Enhance asset handling: add XMP file parsing and manage asset tags during upload * Add description field to Asset struct and update XMP handling * Add description handling to asset creation and update during upload * Refactor asset handling: update OriginalFileName usage and add FromImmich command for uploads * Comment out Epson Scanner test case in TestGetInfo for grouped handling * Update AlbumContent struct to use pointer for Assets and enhance GetAlbumInfo query handling * Implement album-specific asset retrieval in FromImmich adapter and update command flag for album selection * Comment out unused flags in FromImmich command options for asset retrieval * Add documentation for new `archive --from-immich` and `upload --from-immich` commands with usage details and flags * Update release version to 0.23.0-alpha5 in documentation * Fix grammatical error in documentation for `upload --from-immich` command * Check the tag DateTimeUTC when using exiftool and improve error handling * Refactor FromImmich to use flags.client for API calls instead of a separate client field * Change date string normalization to uppercase in DateMethod.Set * Refactor date formatting in AssetUpload to use a constant TimeFormat and remove redundant CaptureDate assignment * Update release notes for v0.23.0-alpha6 and set default capture date method to NONE * Update dependencies in go.mod and go.sum to latest versions
sweepies
pushed a commit
to sweepies/immich-go
that referenced
this pull request
Jan 27, 2026
* Remove commented-out code related to Google Photos analysis in upload command * Remove commented-out code related to Google Photos analysis in upload command * Merge branch 'next' into archive * Rename Adapter interface to Reader and update references in upload command * Merge branch 'next' into archive * Add AssetWriter interface and implement context-aware asset writing * Refactor LocalAssetWriter to use fs.FS directly and enhance MkdirAll functionality in fshelper * Enhance LocalAssetWriter to track created directories and avoid redundant MkdirAll calls * Add XMP reading and writing functionality with GPS and time conversion * Add album support to Asset and XMP reading/writing functionality * Refactor OpenFile function to return WFile interface for enhanced write capabilities * Add WriteGroup method to AssetWriter and enhance WriteAsset to support album associations * Add album association to assets and enhance import flags for Google Photos integration * Refactor upload command options to streamline flag management and enhance filter handling * Refactor import command to enhance folder options handling and streamline flag management * Refactor upload and archive commands to streamline options handling and add Google Photos archive * Rename Stars field to Rating in Asset struct for clarity * Refactor XMP read and write to write immich image properties using a specific namespace: xmlns:immichgo="http://ns.immich-go.com/immich-go/1.0/" * Enhance XMP file handling in folder read/write operations to support sidecar files * Edit release.md: Add new `archive` command to store photos and videos in a structured folder format * Refactor command flag handling to include parent command context for upload and archive operations * Add job management endpoints and tag handling functionality, thx to benjamonnguyen * Refactor asset retrieval and tagging: Introduce SearchMetadataQuery for filtering and enhance asset structure with rating and tag support * Add Tags support to Asset structure and introduce Tag type for asset tagging * Add FromImmich adapter with flags for asset retrieval and filtering * Refactor client initialization and add FromImmich command for archiving * Add support for tags in XMP asset handling: enhance reader and writer for tag extraction and serialization * Refactor ImmichClient methods and enhance asset handling: rename GetAssetByID to GetAssetInfo, add DownloadAsset method, and improve request handling for album retrieval * Add immichfs package for reading assets from Immich server with file system interface * Refactor FromImmich adapter: enhance asset filtering, and improve error handling * Add support for tags in XMP asset handling: update reader and writer, and add test cases for tag extraction * Enhance client error handling: ensure client opens successfully and manage API trace writer closure * Add Tagged event type to file events: update constants and string mapping * Enhance asset handling: add XMP file parsing and manage asset tags during upload * Add description field to Asset struct and update XMP handling * Add description handling to asset creation and update during upload * Refactor asset handling: update OriginalFileName usage and add FromImmich command for uploads * Comment out Epson Scanner test case in TestGetInfo for grouped handling * Update AlbumContent struct to use pointer for Assets and enhance GetAlbumInfo query handling * Implement album-specific asset retrieval in FromImmich adapter and update command flag for album selection * Comment out unused flags in FromImmich command options for asset retrieval * Add documentation for new `archive --from-immich` and `upload --from-immich` commands with usage details and flags * Update release version to 0.23.0-alpha5 in documentation * Fix grammatical error in documentation for `upload --from-immich` command * Check the tag DateTimeUTC when using exiftool and improve error handling * Refactor FromImmich to use flags.client for API calls instead of a separate client field * Change date string normalization to uppercase in DateMethod.Set * Refactor date formatting in AssetUpload to use a constant TimeFormat and remove redundant CaptureDate assignment * Update release notes for v0.23.0-alpha6 and set default capture date method to NONE * Update dependencies in go.mod and go.sum to latest versions
sweepies
pushed a commit
to sweepies/immich-go
that referenced
this pull request
Jan 27, 2026
* Remove commented-out code related to Google Photos analysis in upload command * Remove commented-out code related to Google Photos analysis in upload command * Merge branch 'next' into archive * Rename Adapter interface to Reader and update references in upload command * Merge branch 'next' into archive * Add AssetWriter interface and implement context-aware asset writing * Refactor LocalAssetWriter to use fs.FS directly and enhance MkdirAll functionality in fshelper * Enhance LocalAssetWriter to track created directories and avoid redundant MkdirAll calls * Add XMP reading and writing functionality with GPS and time conversion * Add album support to Asset and XMP reading/writing functionality * Refactor OpenFile function to return WFile interface for enhanced write capabilities * Add WriteGroup method to AssetWriter and enhance WriteAsset to support album associations * Add album association to assets and enhance import flags for Google Photos integration * Refactor upload command options to streamline flag management and enhance filter handling * Refactor import command to enhance folder options handling and streamline flag management * Refactor upload and archive commands to streamline options handling and add Google Photos archive * Rename Stars field to Rating in Asset struct for clarity * Refactor XMP read and write to write immich image properties using a specific namespace: xmlns:immichgo="http://ns.immich-go.com/immich-go/1.0/" * Enhance XMP file handling in folder read/write operations to support sidecar files * Edit release.md: Add new `archive` command to store photos and videos in a structured folder format * Refactor command flag handling to include parent command context for upload and archive operations * Add job management endpoints and tag handling functionality, thx to benjamonnguyen * Refactor asset retrieval and tagging: Introduce SearchMetadataQuery for filtering and enhance asset structure with rating and tag support * Add Tags support to Asset structure and introduce Tag type for asset tagging * Add FromImmich adapter with flags for asset retrieval and filtering * Refactor client initialization and add FromImmich command for archiving * Add support for tags in XMP asset handling: enhance reader and writer for tag extraction and serialization * Refactor ImmichClient methods and enhance asset handling: rename GetAssetByID to GetAssetInfo, add DownloadAsset method, and improve request handling for album retrieval * Add immichfs package for reading assets from Immich server with file system interface * Refactor FromImmich adapter: enhance asset filtering, and improve error handling * Add support for tags in XMP asset handling: update reader and writer, and add test cases for tag extraction * Enhance client error handling: ensure client opens successfully and manage API trace writer closure * Add Tagged event type to file events: update constants and string mapping * Enhance asset handling: add XMP file parsing and manage asset tags during upload * Add description field to Asset struct and update XMP handling * Add description handling to asset creation and update during upload * Refactor asset handling: update OriginalFileName usage and add FromImmich command for uploads * Comment out Epson Scanner test case in TestGetInfo for grouped handling * Update AlbumContent struct to use pointer for Assets and enhance GetAlbumInfo query handling * Implement album-specific asset retrieval in FromImmich adapter and update command flag for album selection * Comment out unused flags in FromImmich command options for asset retrieval * Add documentation for new `archive --from-immich` and `upload --from-immich` commands with usage details and flags * Update release version to 0.23.0-alpha5 in documentation * Fix grammatical error in documentation for `upload --from-immich` command * Check the tag DateTimeUTC when using exiftool and improve error handling * Refactor FromImmich to use flags.client for API calls instead of a separate client field * Change date string normalization to uppercase in DateMethod.Set * Refactor date formatting in AssetUpload to use a constant TimeFormat and remove redundant CaptureDate assignment * Update release notes for v0.23.0-alpha6 and set default capture date method to NONE * Update dependencies in go.mod and go.sum to latest versions Former-commit-id: 0a94e89
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.