This repository was archived by the owner on Feb 16, 2026. It is now read-only.
Added SEO Metadata#97
Open
gdcsinaptik wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 3aed27d in 2 minutes and 15 seconds. Click for details.
- Reviewed
320lines of code in6files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. examples/ui/frontend/src/app/metadata.ts:109
- Draft comment:
The generatePageMetadata wrapper adds no extra functionality; consider consolidating it with generateMetadata for clarity. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. examples/ui/frontend/scripts/test-metadata.js:101
- Draft comment:
Ensure process.cwd() returns the project root; file existence checks might fail if run from a different directory. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_Sa9gLO87Q5Rp0R07
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| address: false, | ||
| telephone: false, | ||
| }, | ||
| metadataBase: new URL(baseUrl), |
Contributor
There was a problem hiding this comment.
Validate that NEXT_PUBLIC_BASE_URL is defined to prevent runtime errors with new URL().
| } | ||
|
|
||
| const baseUrl = process.env.NEXT_PUBLIC_BASE_URL; | ||
| const fullUrl = `${baseUrl}${page.path}`; |
Contributor
There was a problem hiding this comment.
Consider using URL resolution to join baseUrl and page.path to avoid potential double slashes.
Suggested change
| const fullUrl = `${baseUrl}${page.path}`; | |
| const fullUrl = new URL(page.path, baseUrl).toString(); |
| }, | ||
| metadataBase: new URL(baseUrl), | ||
| alternates: { | ||
| canonical: page.path, |
Contributor
There was a problem hiding this comment.
Using a relative path for the canonical alternate may not meet SEO best practices; consider using an absolute URL.
Suggested change
| canonical: page.path, | |
| canonical: fullUrl, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added proper page titles and social sharing previews so the site looks good when shared on social media and ranks better in search results.
Environment Variables
You need to add these to your .env file:
Important
Adds SEO metadata generation and validation, updates layout files, and introduces new environment variables for improved social media sharing and search engine ranking.
generateMetadataandgeneratePageMetadatafunctions inmetadata.tsto generate SEO metadata for pages.layout.tsx,creations/layout.tsx, andupgrade/layout.tsxto usegeneratePageMetadatafor setting page metadata.NEXT_PUBLIC_BASE_URLandGOOGLE_SITE_VERIFICATIONto.env.example.test-metadata.jsscript to validate metadata configuration, checking title, description, keywords, and layout file existence.This description was created by
for 3aed27d. You can customize this summary. It will automatically update as commits are pushed.