-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix: remove deprecated method from documentation #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 26e8e3a in 1 minute and 17 seconds. Click for details.
- Reviewed
74lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/v3/agent.mdx:37
- Draft comment:
Updated header from 'Clarification questions' to 'Follow-up Questions' to reflect the removal of deprecated functions in pandasai3.0. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions for improvement. It simply states what was changed without offering any insight or guidance.
2. docs/v3/agent.mdx:39
- Draft comment:
Removed deprecated code examples (clarification_questions, explain, rephrase_query) to align documentation with pandasai3.0. The new follow_up example correctly demonstrates maintaining conversation context. - Reason this comment was not posted:
Comment looked like it was already resolved.
3. docs/v3/agent.mdx:107
- Draft comment:
Minor text reflow in the Enterprise license note. Ensure the note remains accurate regarding the local vector store training requirements. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to ensure the note remains accurate, which violates the rule against asking the author to ensure behavior is intended. It doesn't provide a specific suggestion or point out a specific issue.
4. docs/v3/agent.mdx:55
- Draft comment:
Line 55: The placeholder "" appears to be incomplete or not formatted as standard Markdown. Consider revising it to a proper note formatting or removing it if not needed. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_nDf25dRw4TZnXT0F
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1842 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 72 72
Lines 2813 2813
=======================================
Hits 2569 2569
Misses 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 8493a35 in 1 minute and 40 seconds. Click for details.
- Reviewed
857lines of code in4files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. docs/v3/migration-backwards-compatibility.mdx:128
- Draft comment:
Good update: The Agent section now clarifies that some methods (clarification_questions, rephrase_query, explain) are removed and introduces the new follow_up() method. This clearly addresses issue #1841. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, providing details about changes made in the code. It does not suggest any improvements, ask for clarifications, or point out potential issues. According to the rules, purely informative comments should be removed.
2. docs/v3/migration-guide.mdx:200
- Draft comment:
Agent section now properly removes deprecated methods and demonstrates the new usage with chat() and follow_up(). This update effectively resolves the outdated documentation for Agent. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, praising the update for resolving outdated documentation. It doesn't provide any actionable feedback or suggestions for improvement.
3. docs/v3/migration-troubleshooting.mdx:59
- Draft comment:
The troubleshooting section now correctly instructs users to use chat() and follow_up() instead of the removed Agent methods. This clear guidance will help mitigate the AttributeError issue. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, praising the change made in the PR. It does not provide any actionable feedback or suggestions for improvement. According to the rules, purely informative comments should be removed.
4. docs/v3/migration-v2-to-v3.mdx:1
- Draft comment:
The entire migration-v2-to-v3.mdx file has been removed. Ensure that all essential migration instructions from this file are consolidated within the remaining migration documents so users are not missing critical migration information. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_gOxgzY9pOTIBetXl
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Important
Update documentation to remove deprecated methods and guide users on migrating to PandasAI v3 with new features like
follow_up().clarification_questions(),explain(), andrephrase_query()fromdocs/v3/agent.mdx.follow_up()method indocs/v3/agent.mdxfor maintaining conversation context.docs/v3/migration-backwards-compatibility.mdxto reflect changes in agent methods and recommend usingpai.DataFrame()andpai.chat().docs/v3/migration-guide.mdxto guide users on migrating from v2 to v3, emphasizing global configuration and new method usage.docs/v3/migration-troubleshooting.mdx, focusing on method removals and configuration changes.This description was created by
for 8493a35. You can customize this summary. It will automatically update as commits are pushed.