-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: add Python 3.12 support #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Update Python version constraint to >=3.9,<3.13 across all packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 787c44f in 1 minute and 14 seconds. Click for details.
- Reviewed
263lines of code in17files - Skipped
1files when reviewing. - Skipped posting
17draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/ci-core.yml:14
- Draft comment:
Added Python 3.12 to the CI matrix. Confirm that all dependencies support it. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. .github/workflows/ci-extensions.yml:14
- Draft comment:
Python 3.12 is now tested for extensions. This ensures broader compatibility. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. extensions/connectors/sql/pyproject.toml:10
- Draft comment:
Python version constraint updated to '>=3.9,<3.13' for SQL connector support on Python 3.12. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. extensions/connectors/yfinance/pyproject.toml:10
- Draft comment:
Updated Python constraint to support Python 3.12. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. extensions/ee/connectors/bigquery/pyproject.toml:14
- Draft comment:
Python version updated to '>=3.9,<3.13' ensuring BigQuery connector works with Python 3.12. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
6. extensions/ee/connectors/databricks/pyproject.toml:14
- Draft comment:
Adjusted python requirement to '>=3.9,<3.13' for Databricks integration. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
7. extensions/ee/connectors/oracle/pyproject.toml:14
- Draft comment:
Python version constraint updated for Oracle connector to support Python 3.12. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
8. extensions/ee/connectors/snowflake/pyproject.toml:14
- Draft comment:
Snowflake connector's python version constraint updated to '>=3.9,<3.13'. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
9. extensions/ee/vectorstores/chromadb/pyproject.toml:14
- Draft comment:
Updated python constraint and numpy version to '^1.24.0' for Chromadb integration. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
10. extensions/ee/vectorstores/lancedb/pyproject.toml:14
- Draft comment:
Adjusted python version to '>=3.9,<3.13' and updated numpy to '^1.24.0' for LanceDB. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
11. extensions/ee/vectorstores/milvus/pyproject.toml:14
- Draft comment:
Python version updated and numpy version set to '^1.24.0' for Milvus integration. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
12. extensions/ee/vectorstores/pinecone/pyproject.toml:14
- Draft comment:
Updated python version constraint and numpy requirement for Pinecone to support Python 3.12. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
13. extensions/ee/vectorstores/qdrant/pyproject.toml:14
- Draft comment:
Revised python version constraint to support Python 3.12 and numpy updated to '^1.24.0' in Qdrant integration. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
14. extensions/llms/litellm/pyproject.toml:14
- Draft comment:
Python version constraint updated to '>=3.9,<3.13' for LiteLLM. Note: This change drops support for Python 3.8. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
15. extensions/llms/openai/pyproject.toml:14
- Draft comment:
Updated python version to '>=3.9,<3.13' to allow Python 3.12 in OpenAI integration. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
16. extensions/sandbox/docker/pyproject.toml:15
- Draft comment:
Python constraint updated to '>=3.9,<3.13' for the Docker extension; ensure Docker image uses supported Python. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
17. pyproject.toml:15
- Draft comment:
Core package's python version updated to '>=3.9,<3.13' along with dependency version bumps. This aligns main package with Python 3.12 support. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_MYvVwyaIDzNzMn6c
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Great work, this would unblock us for Python 3.12. |
Summary
3.12>=3.9,<3.13across all packagesNote: CI might fail because
pandasaiis not yet published to PyPI with Python3.12support.Important
Add support for Python 3.12 by updating version constraints and dependencies in CI workflows and
pyproject.tomlfiles..github/workflows/ci-core.ymland.github/workflows/ci-extensions.yml.>=3.9,<3.13inpyproject.tomland 15 otherpyproject.tomlfiles.numpyto^1.24.0inpyproject.tomland 7 otherpyproject.tomlfiles.scipyto^1.11.0andmatplotlibto^3.7.1inpyproject.toml.pandasainot yet supporting Python 3.12 on PyPI.This description was created by
for 787c44f. You can customize this summary. It will automatically update as commits are pushed.