Skip to content

Fix: Apply SemanticLayerSchema.limit when assigning schema to DataFrame#1879

Open
bala-venkatesh wants to merge 2 commits into
sinaptik-ai:mainfrom
bala-venkatesh:fix-schema-limit
Open

Fix: Apply SemanticLayerSchema.limit when assigning schema to DataFrame#1879
bala-venkatesh wants to merge 2 commits into
sinaptik-ai:mainfrom
bala-venkatesh:fix-schema-limit

Conversation

@bala-venkatesh

@bala-venkatesh bala-venkatesh commented Mar 4, 2026

Copy link
Copy Markdown

Bug

SemanticLayerSchema.limit is not applied when assigning a schema to a DataFrame created using pai.read_csv().

Fix

Added logic in the DataFrame.schema setter to enforce row limits when a schema with limit is assigned.

Testing

All existing tests pass locally (563 passed, 74 skipped).
Added unit test for schema limit behavior.


Important

Fixes bug by enforcing SemanticLayerSchema.limit in DataFrame schema setter and adds a test for this behavior.

  • Behavior:
    • Fixes bug where SemanticLayerSchema.limit was not applied when assigning a schema to a DataFrame created using pai.read_csv().
    • Modifies schema setter in DataFrame to enforce row limits when a schema with a limit is assigned.
  • Testing:
    • Adds test_schema_limit_applied_when_schema_assigned() in test_schema_limit.py to verify schema limit behavior.

This description was created by Ellipsis for 7104124. You can customize this summary. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 7104124 in 8 seconds. Click for details.
  • Reviewed 74 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_gDiUPihT0u5K6qM9

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant