Fix: Apply SemanticLayerSchema.limit when assigning schema to DataFrame#1879
Open
bala-venkatesh wants to merge 2 commits into
Open
Fix: Apply SemanticLayerSchema.limit when assigning schema to DataFrame#1879bala-venkatesh wants to merge 2 commits into
bala-venkatesh wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 7104124 in 8 seconds. Click for details.
- Reviewed
74lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_gDiUPihT0u5K6qM9
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
SemanticLayerSchema.limit is not applied when assigning a schema to a DataFrame created using pai.read_csv().
Fix
Added logic in the DataFrame.schema setter to enforce row limits when a schema with limit is assigned.
Testing
All existing tests pass locally (563 passed, 74 skipped).
Added unit test for schema limit behavior.
Important
Fixes bug by enforcing
SemanticLayerSchema.limitinDataFrameschema setter and adds a test for this behavior.SemanticLayerSchema.limitwas not applied when assigning a schema to a DataFrame created usingpai.read_csv().schemasetter inDataFrameto enforce row limits when a schema with a limit is assigned.test_schema_limit_applied_when_schema_assigned()intest_schema_limit.pyto verify schema limit behavior.This description was created by
for 7104124. You can customize this summary. It will automatically update as commits are pushed.