Version 1.0.23#1378
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts changes to automatically remap TLocalizedValidationError to StandardSchemaV1.Issue through the StandardSchemaV1 interface.
This decision was made to prevent TypeBox generating two forms of error, and where there are currently ambiguous interpretations of the current
pathsegments described in the Standard Schema specification. Other considerations relate to user defined errors via Type.Base (which do not mandate any particular structure and are for all intents and purposes opaque), along with technicalities regarding TypeBox being able to embed Standard Schema in Json Schema schematics.This functionality may be re-investigated in future, but is removed as a protection measure to mitigate undue complexity entering TypeBox internals.
Relates: #1368