Add Guidelines#3322
Conversation
|
That’s a great list! I starred it immediately! 😊 From a content perspective, it’s already excellent, but I noticed a couple of things regarding the format:
|
|
@Kristories Nice list! Some things:
|
|
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
|
unicorn |
@sindresorhus I’ve gone through the guidelines carefully and have revised my submission accordingly. Please let me know if there’s anything else that needs adjustment. I appreciate the time and effort you put into creating the guidelines and maintaining Awesome! |
|
This is what I need to learn...I only recently have had the time... |
|
Great list! One suggestions:
Everything else looks solid. ✅ |
0abcf16 to
393b934
Compare
|
Hi @sindresorhus, Is there anything specific about the PR that needs attention, or would you like me to make any adjustments to better align with the awesome list standards? Thanks for your time. |
62ee821 to
f6363b6
Compare
Descriptions should not be title-case. |
Updated the descriptions — no longer in title case. Thanks for the review! 🦄 @sindresorhus |
Not fixed |
Done @sindresorhus |
Insufficient reviewsThe template requires 4 substantive reviews. Of the 4 PRs you listed:
That's 1 qualifying review out of the 4 required. Blank approvals with no body or comments do not count per the template: "Just commenting 'looks good' or simply marking the pull request as approved does not count!" You need 3 more substantive reviews where you point out specific guideline violations or improvement suggestions. Top description describes the list, not the subjectCurrent:
"A set of guidelines...that provides recommendations" describes what the list is, not what the subject is. This matches the explicitly prohibited pattern ("Resources and tools for X"). Something like "Programming style, best practices, and coding conventions." would work. Entry not placed at the bottomThe diff inserts the entry between Permacomputing and Standards. The guideline requires it to be "at the bottom of the appropriate category" -- it should go after the last entry (currently Copilot Agents), right before the Linked list issuesMany entries have no description (13 total)The guideline says "Entries have a description, unless the title is descriptive enough by itself. It rarely is though." These entries have no description at all:
Broken linksThese are dead or point to unrelated content:
Stale redirect
Description issues
ImageThe header image ( |
|
Your awesome list URL should end in #readme |
|
What am i supposed to be doing here |
sn7zvqtvhf-star
left a comment
There was a problem hiding this comment.
I am the original creator and technical owner of this work, repository, and associated assets. I retain full authorship and ownership rights.
|
@sindresorhus updated. Please check |
|
Heya @Kristories !
This, also including entries inside Frameworks and Content Management System Sections should apply this guideline.
After this, recommend rechecking the README again to make sure it follows all the guidelines. |
velo4705
left a comment
There was a problem hiding this comment.
So I found some things to correct, kinda taken from my previous comment:
- Some entries in the list do not have a description yet ("Entries have a description, unless the title is descriptive enough by itself. It rarely is though."). These are:
[Style Guide](...)[Google Common Lisp Style Guide](...)[Erlang Coding Guidelines](...)[Java Programming Style Guide](...)[Mozilla Coding Style Guide for JavaScript](...)[Rust Style Guide](...)[API Style Guide for Arduino](...)[LESS Coding Guidelines](...)[Google HTML/CSS Style Guide](...)[Semantic Versioning](...)[Indent style](...)[CodeQL Coding Standards](...)
This, also including entries inside Frameworks and Content Management System Sections should apply this guideline.
- There is this deprecated entry that is actually an archived repository ("Does not contain items that are unmaintained, has archived repo, deprecated, or missing docs. If you really need to include such items, they should be in a separate Markdown file."). I suggest to remove them from the list or else move them to a separate Markdown file:
[Metova's Swift style guide](...) - Swift style guide for Xcode (archived, deprecated 2022).
After this, try rechecking the list again to make sure it follows all the guidelines.
Other than that, the List fits as Awesome. ✨
[Insert URL to the list here]
https://github.com/Kristories/awesome-guidelines
[Explain what this list is about and why it should be included here]
A curated list of programming guidelines to enhance code quality and promote best practices.
My Reviews of Other PRs
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions. Comments pointing out lint violation are allowed, but does not count as a review.
Add Name of List. It should not contain the wordAwesome.Add SwiftAdd Software ArchitectureUpdate readme.mdAdd Awesome SwiftAdd swiftadd SwiftAdding SwiftAdded Swift- [iOS](…) - Mobile operating system for Apple phones and tablets.- [Framer](…) - Prototyping interactive UI designs.- [iOS](…) - Resources and tools for iOS development.- [Framer](…)- [Framer](…) - prototyping interactive UI designs#readme.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-linton your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main, notmaster.Mobile operating system for Apple phones and tablets.Prototyping interactive UI designs.Resources and tools for iOS development.Awesome Framer packages and tools.If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list.awesome-swiftawesome-web-typographyawesome-SwiftAwesomeWebTypography# Awesome Name of List.# Awesome Swift# Awesome Web Typography# awesome-swift# AwesomeSwiftawesome-list&awesomeas GitHub topics. I encourage you to add more relevant topics.Awesome Xand a logo withAwesome X. You can put the header image in a#(Markdown header) or<h1>.Contents, notTable of Contents.ContributingorFootnotessections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0(replace<user>and<repo>accordingly).licenseorLICENSEin the repo root with the license text.Licencesection to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn.contributing.md. The casing is up to you.Contributing, positioned at the top or bottom of the main content.Footnotessection at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.Node.js, notNodeJSornode.js.You can still use a CI for linting, but the badge has no value in the readme.
Inspired by awesome-fooorInspired by the Awesome projectkinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.