export ConditionalSimplify and ConditionalSimplifyDeep
#1094
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request exports the ConditionalSimplify and ConditionalSimplifyDeep types and updates the tests and documentation accordingly.
- Removed deep simplification tests from conditional-simplify.ts to separate concerns.
- Added full test coverage for ConditionalSimplifyDeep in a dedicated file.
- Updated readme.md to include entries for the newly exported types.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-d/conditional-simplify.ts | Removed deep tests and adjusted the import to use the new index. |
| test-d/conditional-simplify-deep.ts | Added comprehensive tests for ConditionalSimplifyDeep. |
| readme.md | Updated documentation to include the new exports. |
| // Should simplify interface deeply. | ||
| type SomeNode = { | ||
| parent: PositionAndSizeIntersection; | ||
| childs: Array<{parent: PositionAndSizeIntersection}>; |
There was a problem hiding this comment.
Consider renaming 'childs' to 'children' for correct plural form.
Copilot uses AI. Check for mistakes.
|
There is never any need to open multiple pull requests. If you made a mistake, you can simply force push to the same branch. Multiple closed pull requests adds needless noise to the our notifications. |
| @@ -0,0 +1,62 @@ | |||
| /** | |||
| Recursively simplifies a type while including and/or excluding certain types from being simplified. | |||
There was a problem hiding this comment.
Please preserve the code example like it was originally, this includes empty lines.
There was a problem hiding this comment.
@romanywu I was talking in general, not just this example. All the code.
|
|
||
| @example | ||
| ```ts | ||
| import type {ConditionalSimplifyDeep} from 'type-fest'; |
There was a problem hiding this comment.
| import type {ConditionalSimplifyDeep} from 'type-fest'; | |
| import type {ConditionalSimplifyDeep} from 'type-fest'; | |
closed #1005