export ConditionalSimplify and ConditionalSimplifyDeep
#1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request exports the ConditionalSimplify and ConditionalSimplifyDeep types and updates the tests and documentation accordingly.
- Removed deep simplification tests from conditional-simplify.ts to separate concerns.
- Added full test coverage for ConditionalSimplifyDeep in a dedicated file.
- Updated readme.md to include entries for the newly exported types.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-d/conditional-simplify.ts | Removed deep tests and adjusted the import to use the new index. |
| test-d/conditional-simplify-deep.ts | Added comprehensive tests for ConditionalSimplifyDeep. |
| readme.md | Updated documentation to include the new exports. |
| // Should simplify interface deeply. | ||
| type SomeNode = { | ||
| parent: PositionAndSizeIntersection; | ||
| childs: Array<{parent: PositionAndSizeIntersection}>; |
There was a problem hiding this comment.
Consider renaming 'childs' to 'children' for correct plural form.
Copilot uses AI. Check for mistakes.
|
There is never any need to open multiple pull requests. If you made a mistake, you can simply force push to the same branch. Multiple closed pull requests adds needless noise to the our notifications. |
sindresorhus
reviewed
Apr 1, 2025
Emiyaaaaa
approved these changes
Apr 7, 2025
sindresorhus
reviewed
May 7, 2025
sindresorhus
force-pushed
the
main
branch
2 times, most recently
from
eabb987 to
cc2b0f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #1005