Add ExtractStrict and ExcludeStrict types
#291
Conversation
|
Thanks for contributing these types. Make sure you read and adhere to https://github.com/sindresorhus/type-fest/blob/main/.github/contributing.md |
|
You also need to add the types to the readme. |
| @@ -0,0 +1,18 @@ | |||
| /** | |||
| Constructs a type by excluding from Type all union members that are assignable to ExcludedUnion. | |||
There was a problem hiding this comment.
I think this description could be written a little bit clearer.
I think this would be a requirement for this to be merged as otherwise it's not proven that these types actually work, even if they do, they might accidentally regress in the future. Did you try using |
I agree one hundred percent 😅
Yeah, but I did not succeed after trying for 30 minutes. I'll just try again; I'm sure I'll manage if I give it enough time. I'll come back to fix this this sometime within the next few months. |
| //=> 'xxxl' | 'xxl' | 'xl' | 'l'; | ||
| ``` | ||
|
|
||
| @category Utilities |
There was a problem hiding this comment.
I think we should also have a category for utilities that are better versions of builtins. Maybe called Improved builtin?
| @category Utilities | |
| @category Improved builtin |
|
Please excuse me for taking so long to incorporate your suggestions, @sindresorhus. I'm currently finishing a book, and I do not expect to have time to finish this PR before the middle of February. |
No worries. I'll leave this open until you have some time. |
sindresorhus
force-pushed
the
main
branch
3 times, most recently
from
29f3df0 to
08de69b
Compare
|
Friendly bump :) |
Solves #222
I could not figure out how to make test cases to demonstrate that these types fail when you supply an ExcludedUnion or Union that includes an element which is not found in Type. If someone knows how, a contribution is very welcome!