Formatting code as per the standards using pre-commit config#51
Open
rdeshmukh15 wants to merge 3 commits intocrest-workfrom
Open
Formatting code as per the standards using pre-commit config#51rdeshmukh15 wants to merge 3 commits intocrest-workfrom
rdeshmukh15 wants to merge 3 commits intocrest-workfrom
Conversation
Member
|
Please delete the .vscode folder and its settings.json |
vishalp-dev
reviewed
Feb 2, 2023
Comment on lines
142
to
145
| def is_bookmark_old(self, value): | ||
| bookmark = self.get_bookmark() | ||
| return utils.strptime_to_utc(value) >= bookmark | ||
|
|
Member
There was a problem hiding this comment.
unnecessary abstraction of function
vishalp-dev
reviewed
Feb 2, 2023
Comment on lines
108
to
111
| for stream in Context.catalog["streams"]: | ||
| if Context.is_selected(stream["tap_stream_id"]): | ||
| singer.write_schema(stream["tap_stream_id"], | ||
| stream["schema"], | ||
| stream["key_properties"]) | ||
| singer.write_schema(stream["tap_stream_id"], stream["schema"], stream["key_properties"]) | ||
| Context.counts[stream["tap_stream_id"]] = 0 |
Member
There was a problem hiding this comment.
can use the following function instead
catalog.get_selected_streams(state):
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Formatting code as per the standards using pre-commit config
Manual QA steps
Risks
Rollback steps