changes to line 430 to accept number and string#18
Conversation
|
Hi @shikharjaiswal67, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
|
You did it @shikharjaiswal67! Thank you for signing the Singer Contribution License Agreement. |
shikharjaiswal67
changed the title
|
I am seeing this same issue with Stitch, how would I go about getting this fix utilized in our integration? |
probably send a message in their slack channel or to the repo owner directly. |
|
@luandy64 |
| }, | ||
| "value": { | ||
| "$ref": "type-number.json" | ||
| "type": ["number", "string", "null"] |
There was a problem hiding this comment.
I was wondering about the necessity of maintaining two separate datatypes. The documentation specifically mentions the datatype as string. Should we consider eliminating the number datatype altogether?
Having both datatypes may lead to the creation of two columns in the destination table, each with a different datatype (number and string). What are your thoughts on this?
There was a problem hiding this comment.
hi @sgandhi1311 ,
Agreed with you as there is no need for both datatypes. I will create update the PR and let you know.
|
I can merge it into the master branch; however, I've included a comment that needs attention before finalizing the merge. |
|
@sgandhi1311 - i have made the necessary changes. can you please review and approve it. Let me know for any issues. thank you. |
4 participants
Description of change
product.product_options.value is defined as a string in the BigCommerce v2 API documentation. This request is related to issue #17 where value's in the BigCommerce source are strings and the insert fails for these orders.
The BigCommerce API docs which indicate the product_options.value is a string [(https://developer.bigcommerce.com/api-reference/3b4dfef625708-list-order-products)]
Screenshot for BigCommerce API doc
https://drive.google.com/file/d/1G4Y9JX7bcdVsbml-MzB8hHrUEx_NpZPL/view?usp=sharing
Manual QA steps
Verify string and integer product_options.value are being passed through the Tap
Risks
Rollback steps