TDL-18524 updated readme and added sample config#100
Open
namrata270998 wants to merge 5 commits into
Open
Conversation
namrata270998
changed the title
namrata270998
requested review from
dbshah1212,
savan-chovatiya and
umangagrawal-crest
umangagrawal-crest
approved these changes
May 3, 2022
savan-chovatiya
approved these changes
May 3, 2022
dbshah1212
approved these changes
May 3, 2022
kspeer825
reviewed
May 9, 2022
kspeer825
left a comment
kspeer825
left a comment
Contributor
There was a problem hiding this comment.
Would be good to include the bookmarking strategy like how tap-square has here https://github.com/singer-io/tap-square.
RushiT0122
approved these changes
May 10, 2022
Contributor
Author
Added bookmarking strategy |
kspeer825
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps