Skip to content

Sync streams one at a time#108

Open
luandy64 wants to merge 2 commits into
masterfrom
TDL-22039-single-stream-sync
Open

Sync streams one at a time#108
luandy64 wants to merge 2 commits into
masterfrom
TDL-22039-single-stream-sync

Conversation

@luandy64

Copy link
Copy Markdown

Description of change

This PR alters the tap code to run tasks for a single stream at a time.

Previously, the tap would create tasks for every selected stream, which resulted in SDK calls to Bing services all at once. This seems to cause an internal error occasionally.

Manual QA steps

  • Ran the tap to see that syncing all selected streams still occurred

Risks

  • Moderate. I was not able to reproduce the Internal Error myself. But nothing went wrong while running this code.
  • If this were to be merged, I'm not sure how it would affect people running this tap with a ton of accounts. Maybe some people actually rely on the async calls to all happen at once. This removes some of that, so data extraction times would almost certainly go up

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants