Add table-key-properties to key_property#72
Open
EmaLoprevite wants to merge 1 commit into
Open
Conversation
Allow `table-key-properties` to be added to the metadata and put into `key_property` in the SCHEMA, this way a target will be able to read the primary keys.
ilkkapeltola
approved these changes
Jun 29, 2022
ilkkapeltola
left a comment
ilkkapeltola
left a comment
There was a problem hiding this comment.
This looks like a good solution to the problem.
|
@kspeer825 could you have a look at this. This PR would make the tap significantly more useful when the target knows which primary keys to use in reports. Without this, I cannot load into Snowflake as there's no information on primary keys. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Allow
table-key-propertiesto be added to the metadata and put intokey_propertyin the SCHEMA, this way a target will be able to read the primary keys.Manual QA steps
Risks
table-key-propertiesis not defined, it will default to[].Rollback steps