Skip to content

bump version for attrs to 17.3.0#109

Open
pblankley wants to merge 1 commit into
singer-io:masterfrom
pblankley:master
Open

bump version for attrs to 17.3.0#109
pblankley wants to merge 1 commit into
singer-io:masterfrom
pblankley:master

Conversation

@pblankley

Copy link
Copy Markdown

Description of change

The current version fails of attrs fails with a aiohttp conflict. See this issue

Manual QA steps

  • Ran tap-facebook using meltano and successfully took live data from my personal facebook ads account into snowflake.

Risks

  • This may break features I'm unaware of that rely specifically on attrs==16.3.0

Rollback steps

  • revert this branch

@cmerrick

Copy link
Copy Markdown
Contributor

Hi @pblankley, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick

Copy link
Copy Markdown
Contributor

You did it @pblankley!

Thank you for signing the Singer Contribution License Agreement.

@pblankley

Copy link
Copy Markdown
Author

Any thoughts on this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants