Skip to content

Fixes link to spec 404#111

Open
auyer wants to merge 1 commit intosinger-io:masterfrom
auyer:patch-1
Open

Fixes link to spec 404#111
auyer wants to merge 1 commit intosinger-io:masterfrom
auyer:patch-1

Conversation

@auyer
Copy link

@auyer auyer commented Oct 8, 2020

The previous link to the singer spec yielded a 404 error, because the file SPEC.md was moved to docs/SPEC.md

There still is a SPEC.md file located in a sub folder (link to file).
If that is the intended file, send a message in the PR and I'll make the change.

Update: I've checked different taps and decided that the second option (in the striked part) was correct. I've commited the change and squashed both commits.

Description of change

Link to spec in the docs was corrected

Manual QA steps

  • click the new link
  • check if the docs are the ones intended

Risks

  • none

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

cmerrick commented Oct 8, 2020

Hi @auyer, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

cmerrick commented Oct 8, 2020

You did it @auyer!

Thank you for signing the Singer Contribution License Agreement.

The previous link to the singer spec yielded a 404 error, because the file `SPEC.md` was moved to docs/SPEC.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants