Skip to content

Remove ads.creative.creative_id in favor of ads.creative.id#113

Open
cosimon wants to merge 1 commit intomasterfrom
schema/remove-creative-id
Open

Remove ads.creative.creative_id in favor of ads.creative.id#113
cosimon wants to merge 1 commit intomasterfrom
schema/remove-creative-id

Conversation

@cosimon
Copy link
Contributor

@cosimon cosimon commented Nov 12, 2020

Description of change

ads.creative.creative_id is not returned by the facebook api, so remove it from the schema. ads.creative.id is the id of the creative on the ad.

Manual QA steps

Risks

  • Potential for customers with old versions of facebook ads in which this is returned. This field has been around since the creation of the tap.

Rollback steps

  • revert this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant