TDL-6619: Enable leads stream#180
Open
savan-chovatiya wants to merge 2 commits into
Open
Conversation
savan-chovatiya
commented
Dec 2, 2021
Comment on lines
+490
to
+491
| if latest_lead: | ||
| return str(pendulum.parse(latest_lead[self.replication_key])) |
Contributor
Author
There was a problem hiding this comment.
Added above condition because the tap was breaking(parsing None as a date error) when no data is available for leads.
The above function returns the maximum replication key's value out of all leads for writing bookmark.
savan-chovatiya
commented
Dec 2, 2021
| 'ads_insights_dma', | ||
| "ads_insights_hourly_advertiser", | ||
| #'leads', | ||
| 'leads', |
Contributor
Author
There was a problem hiding this comment.
This is enabled as it's used in discover mode.
savan-chovatiya
requested review from
KrisPersonal,
cosimon,
kspeer825 and
umangagrawal-crest
umangagrawal-crest
approved these changes
Dec 2, 2021
kspeer825
suggested changes
Dec 2, 2021
kspeer825
left a comment
kspeer825
left a comment
Contributor
There was a problem hiding this comment.
I believe there is test data for this stream, see my comment on the ticket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-6619: Enable leads stream.
NOTE: No data available currently for leads and for that we need to create/activate ads and do some interaction but it's chargeable activity. As per card comment, scope related to 'leads' is already added in the OAuth app and marked ready to use so we will comment integration tests to not consider 'leads' stream in sync-related tests for now as per discussion.
Manual QA steps
Risks
Rollback steps