Add country to ads insights country breakdown PK#90
Open
Conversation
shyamodedraRK
approved these changes
Sep 10, 2020
shyamodedraRK
approved these changes
Sep 14, 2020
|
I've encountered this issue with a redshift target https://github.com/transferwise/pipelinewise-target-redshift. Resulting in ads_insights_country only having one row per day (1 country), regardless of how much data and countries tap-facebook extracted |
|
Same issue here, surely this report does not work as it stands so the breaking change this pull requests involves in changing the PK is needed ASAP... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
It seems that
ads_insights_countryis missing thecountryproperty from its Primary Key. This may cause targets that deduplicate based on the PK to have incorrect totals in situations where the values that were split by country get deduplicated back to the record as defined by the base insights PK.Manual QA steps
Risks
Rollback steps